[PC-BSD Pbi-dev] Small patch
kris at pcbsd.org
Fri Nov 11 08:25:54 PST 2011
-----BEGIN PGP SIGNED MESSAGE-----
On 11/07/2011 15:22, Baptiste Daroussin wrote:
> here is a small patch to use realpath(3) instead of ls -l | awk
> I think the best would be to directly use realpath instead of
get_abspath but I
> didn't want to be too much intrusive.
> Before sending more patches, I see you often use:
> if [ something ]; then return, fi
> in general I prefer
> [ something ] && return
> but that's is a matter of choice, I find the second more readable, but
> sending you patches you won't accept, I prefer asking, would you accept
> kind of patches?
I will accept those kind of patches since they both make sense to me :)
> You also often use expr(1) you sh provide some native way to do the
> stuff, would you accept patches to use sh builting things when possible?
That's fine! Send them over.
> last you often to
> cmd ...
> if [ $? -eq ]; then
> where you would simple
> if cmd; then
> of cmd && ...
> depending of the cases
> Would those one be accepted to or would that be against your style.
Again, I'm pretty style-agnostic, so feel free to send adjustments if
they improve speed / readability.
> Sorry for the boring mail, but I prefer to understand your coding rules
> sending useless patches.
> Pbi-dev mailing list
> Pbi-dev at lists.pcbsd.org
I've also just commited the realpath fix, thanks!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Pbi-dev