[PC-BSD Pbi-dev] Small patch

Kris Moore kris at pcbsd.org
Fri Nov 11 08:25:54 PST 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/07/2011 15:22, Baptiste Daroussin wrote:
> Hi,
>
> here is a small patch to use realpath(3) instead of ls -l | awk
>
> I think the best would be to directly use realpath instead of
get_abspath but I
> didn't want to be too much intrusive.
>
> Before sending more patches, I see you often use:
> if [ something ]; then return, fi
>
> in general I prefer
> [ something ] && return
>
> but that's is a matter of choice, I find the second more readable, but
before
> sending you patches you won't accept, I prefer asking, would you accept
that
> kind of patches?
I will accept those kind of patches since they both make sense to me :)

>
> You also often use expr(1) you sh provide some native way to do the
mathematical
> stuff, would you accept patches to use sh builting things when possible?

That's fine! Send them over.
>
> last you often to
> cmd ...
> if [ $? -eq ]; then
> return
> fi
>
> where you would simple
> if cmd; then
> ...
> fi
>
> of cmd && ...
> depending of the cases
>
> Would those one be accepted to or would that be against your style.
Again, I'm pretty style-agnostic, so feel free to send adjustments if
they improve speed / readability.

>
> Sorry for the boring mail, but I prefer to understand your coding rules
before
> sending useless patches.
>
> regards,
> Bapt
>
>
> _______________________________________________
> Pbi-dev mailing list
> Pbi-dev at lists.pcbsd.org
> http://lists.pcbsd.org/mailman/listinfo/pbi-dev

I've also just commited the realpath fix, thanks!

- -- 
Kris Moore
PC-BSD Software
iXsystems
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOvUySAAoJEH/cIgwwV3zXLRQH+wXGqQJz7vygmgbpAd8Vc2la
CVvnxYrdKw/MOmKCfoGutwnOAjQgX6I6/Ed4uZpPEQj5pcbvF2qg7aeEsfIYPKE6
OG/mmoapH2x6GO6TIWemwu6ifzNZEnnP4o3q58rTpXnJNBU0uJCCS67mOQod6EUy
Eeiq1k6kZuzrfir3+Nh8J6s2gLGIoSt2QfgJhe+F9gO51Z900xXa8RO4H7PUoD4B
twHn1dLj8WOYy/FSaHxPvFHwfFrT7UBZFPdHGMtfU6HceZJk7cE29ihizaU+nQba
CUW2mEkKEap8YEsZmhvxmjTu/HTadj9Cm0IyBbzs1HQRtrbgcLfCCMyFap1imlY=
=CkAx
-----END PGP SIGNATURE-----

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pcbsd.org/pipermail/pbi-dev/attachments/20111111/fd6a794c/attachment.html>


More information about the Pbi-dev mailing list