<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 02/25/2012 11:37, Yuri Momotiuk wrote:
<blockquote
cite="mid:CAOf=PiuHm9T9wOKpBVRYP751L3Fo7S8ePw9O5oesdNz9h-7wAA@mail.gmail.com"
type="cite">I have just run cppcheck on src-qt4 dir and got:
<div><br>
</div>
<div>
<div>[pc-netmanager/src/NetworkManager/networkman.cpp:532]:
(error) Mismatching allocation and deallocation: file</div>
<div>[pc-netmanager/src/ethernetconfig/ethernetconfig.cpp:273]:
(error) Mismatching allocation and deallocation: file</div>
<div>[pc-netmanager/src/wificonfig/wificonfigwidgetbase.cpp:687]:
(error) Mismatching allocation and deallocation: file</div>
<div>[pc-pbigui/pbi.cpp:361]: (error) Mismatching allocation and
deallocation: file</div>
<div>[pc-pfmanager/config/interfaces.cpp:53]: (error) Resource
leak: file</div>
<div>[pc-sounddetect/sound_detect.c:150]: (error) Resource leak:
inF</div>
<div>[pc-sysmanager/cvsupprogress.cpp:265]: (error)
Uninitialized variable: nullBox</div>
<div><br>
</div>
<div>Also I saw some potential bugs in code for config
files analyze:</div>
<div>For example line from Utils.cpp (libpcbsd)</div>
<div><br>
</div>
<div><i>if ( line.indexOf("#", 0) == 0 || line.indexOf(Key, 0)
== -1 || line.indexOf(Key, 0) > 0)</i></div>
<div><br>
</div>
<div>should be like this:</div>
<div><br>
</div>
<div><i>if ( line.<b><u>trimmed().</u></b>indexOf("#", 0) == 0
|| line.indexOf(Key, 0) == -1 || line.indexOf(Key, 0) >
0)</i></div>
<div><br>
</div>
<div>Otherwise code can not catch comment if there is space
between "#" in line. Please recheck related code.</div>
<div><br>
</div>
-- <br>
Best regards, Yuri Momotyuk<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Dev@lists.pcbsd.org">Dev@lists.pcbsd.org</a>
<a class="moz-txt-link-freetext" href="http://lists.pcbsd.org/mailman/listinfo/dev">http://lists.pcbsd.org/mailman/listinfo/dev</a>
</pre>
</blockquote>
<br>
Thanks, got all those fixed in SVN :)<br>
<br>
<pre class="moz-signature" cols="72">--
Kris Moore
PC-BSD Software
iXsystems</pre>
</body>
</html>