[PC-BSD Commits] [pcbsd/pcbsd] b43f01: In FreeBSD, set_rcvar() was removed here:

GitHub noreply at github.com
Mon Aug 26 07:01:07 PDT 2013


  Branch: refs/heads/master
  Home:   https://github.com/pcbsd/pcbsd
  Commit: b43f0175c5ace01bfa8ef8b56eee7158629f9e25
      https://github.com/pcbsd/pcbsd/commit/b43f0175c5ace01bfa8ef8b56eee7158629f9e25
  Author: Craig Rodrigues <rodrigc at crodrigues.org>
  Date:   2013-08-25 (Sun, 25 Aug 2013)

  Changed paths:
    M src-qt4/pc-sounddetect/rc.d/pc-sounddetect
    M src-sh/warden/scripts/rc.d/wardenrc

  Log Message:
  -----------
  In FreeBSD, set_rcvar() was removed here:

    |------------------------------------------------------------------------
    |r230103 | dougb | 2012-01-14 00:59:02 -0800 (Sat, 14 Jan 2012) | 6 lines
    |
    |Now that its callers have been udpated, remove set_rcvar().
    |
    |The concept of set_rcvar() was nice in theory, but the forks
    |it creates are a drag on the startup process, which is especially
    |noticeable on slower systems, such as embedded ones.
    |
    |------------------------------------------------------------------------

Perform similar fixes to the PC-BSD startup scripts to accomodate this change
in FreeBSD 10:

    |------------------------------------------------------------------------
    |r230099 | dougb | 2012-01-13 18:18:41 -0800 (Fri, 13 Jan 2012) | 14 lines
    |
    |Prepare for the removal of set_rcvar() by changing the rcvar=
    |assignments to the literal values it would have returned.
    |
    |The concept of set_rcvar() was nice in theory, but the forks
    |it creates are a drag on the startup process, which is especially
    |noticeable on slower systems, such as embedded ones.
    |
    |During the discussion on freebsd-rc@ a preference was expressed for
    |using ${name}_enable instead of the literal values. However the
    |code portability concept doesn't really apply since there are so
    |many other places where the literal name has to be searched for
    |and replaced. Also, using the literal value is also a tiny bit
    |faster than dereferencing the variables, and every little bit helps.
    |
    |------------------------------------------------------------------------


  Commit: 38f550b2501f83376165cd2be4ba1e231cff5fae
      https://github.com/pcbsd/pcbsd/commit/38f550b2501f83376165cd2be4ba1e231cff5fae
  Author: Kris Moore <kris at pcbsd.org>
  Date:   2013-08-26 (Mon, 26 Aug 2013)

  Changed paths:
    M src-qt4/pc-sounddetect/rc.d/pc-sounddetect
    M src-sh/warden/scripts/rc.d/wardenrc

  Log Message:
  -----------
  Merge pull request #2 from rodrigc/master

In FreeBSD, set_rcvar() was removed here:


Compare: https://github.com/pcbsd/pcbsd/compare/449dfba2dc3d...38f550b2501f


More information about the Commits mailing list