[PC-BSD Commits] r19013 - pcbsd/current/src-qt4/libpcbsd

[svn at pcbsd.org]

Author: kris
Date: 2012-09-10 18:35:04 +0000 (Mon, 10 Sep 2012)
New Revision: 19013

Modified:
   pcbsd/current/src-qt4/libpcbsd/metaWidget.cpp
Log:

Fix a bug showing success when the pc-metapkgmanager returned
non 0



Modified: pcbsd/current/src-qt4/libpcbsd/metaWidget.cpp
===================================================================
--- pcbsd/current/src-qt4/libpcbsd/metaWidget.cpp	2012-09-10 18:31:00 UTC (rev 19012)
+++ pcbsd/current/src-qt4/libpcbsd/metaWidget.cpp	2012-09-10 18:35:04 UTC (rev 19013)
@@ -486,16 +486,17 @@
         if ( canceled )
 	      return;
 
-	if ( addMetaProc->exitCode() != 0 && addMetaProc->exitStatus() != QProcess::NormalExit )
+	if ( addMetaProc->exitCode() != 0 || addMetaProc->exitStatus() != QProcess::NormalExit ) {
         	QMessageBox::critical(this, tr("System Packages"),
         	tr("The meta-pkg manager returned an error. For more details please look at the log file:") + " /tmp/.pc-metapkgmanager.log",
         	QMessageBox::Ok,
         	QMessageBox::Ok);
-	else
+	} else {
         	QMessageBox::information(this, tr("System Packages"),
         	tr("System packages updated successfully."),
         	QMessageBox::Ok,
         	QMessageBox::Ok);
+        }
 }
 
 bool metaWidget::getMediaLocation(QString &source, QString &dir)